Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6672 6677 +5
=======================================
Files 795 795
Lines 65878 65893 +15
Branches 9870 9878 +8
=======================================
+ Hits 30679 30688 +9
- Misses 32824 32827 +3
- Partials 2375 2378 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/org/rascalmpl/compiler/lang/rascalcore/check/CheckerCommon.rsc
Outdated
Show resolved
Hide resolved
PaulKlint
left a comment
PaulKlint
left a comment
There was a problem hiding this comment.
First of all, great finding this obscure problem.
The solution looks fine, with one suggestion to improve performance.
PaulKlint
left a comment
PaulKlint
left a comment
There was a problem hiding this comment.
Looks fine to me. This probably the cleanest and fastest solution.
|
There was a problem hiding this comment.
Deze kunnen we nu hier zo laten maar op termijn naar een tools directory moven.
| private map[str, str] MD5_ESCAPES = (MD5_CONTRIB_SEPARATOR: "\\<MD5_CONTRIB_SEPARATOR>"); | ||
|
|
||
| @synopsis{Hash a variable number of contributing values (MD5).} | ||
| str normalizedMD5Hash(value contribs...) |
There was a problem hiding this comment.
Ik vind deze oplossing met varargs heel elegant.
| @@ -556,9 +551,6 @@ void collect(current:(Sym) `<Nonterminal n>[ <{Sym ","}+ parameters> ]`, Collect | |||
| endDefineOrReuseTypeParameters(c); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Mooi dit elimineren van de (kennelijk) niet meer gebruikte md5ContribSym
3 participants
Breaking changes
This PR extends normalisation to the complete MD5 input, meaning that any whitespace will be removed. Therefore, hash signatures for many definitions change.